Skip to content

feature: Describe use of XC-based RBAC #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 5, 2025
Merged

feature: Describe use of XC-based RBAC #248

merged 7 commits into from
Mar 5, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Mar 3, 2025 •
edited
Loading

Proposed changes

Problem: Describe existing XC features usable for RBAC for NGINX One Console

Solution: Organize content as drafted by PM

Note how this PR organizes the drafted content, under "Role-based access control"

Screenshot 2025-03-05 at 8 47 07 AM

When you review the "build" review the content in the ToC, under "Role-based access control".

Closes #209

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@mjang mjang self-assigned this Mar 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/248/

@mjang mjang requested a review from jasonclopper March 3, 2025 19:50
@mjang mjang marked this pull request as ready for review March 3, 2025 19:51
@mjang mjang requested a review from a team as a code owner March 3, 2025 19:51
@mjang
Copy link
Contributor Author

mjang commented Mar 3, 2025

cc @kamalchaturvedi

kamalchaturvedi
kamalchaturvedi reviewed Mar 3, 2025
View reviewed changes
ADubhlaoich
ADubhlaoich approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in a general sense, though I find prefixing document type to page title really heavy-handed and will fight any introduction to a product I'm responsible for.

@JTorreG JTorreG added the product/nginx-one NGINX One Console label Mar 4, 2025
@jasonclopper
Copy link

Nit picky, but at least in the preview image the capitalization after the doc type is inconsistent.

@nginx nginx deleted a comment from mjang Mar 4, 2025
ADubhlaoich
ADubhlaoich reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of edit suggestions, including the excision of the type prefixes. Renamed one title with respect to the context of the section: I had to delete a thread I started earlier to be able to highlight the full block.

mjang and others added 2 commits March 4, 2025 09:49
@mjang
Copy link
Contributor Author

mjang commented Mar 5, 2025

Nit picky, but at least in the preview image the capitalization after the doc type is inconsistent.

Noted and updated per other comments

@mjang
Copy link
Contributor Author

mjang commented Mar 5, 2025

As not all reviewers have approval privileges, I'm merging, based on approval comments.

@mjang mjang merged commit d9836d1 into main Mar 5, 2025
8 checks passed
@mjang mjang deleted the feature-rbac-n1c branch March 5, 2025 16:51
@mjang mjang mentioned this pull request Apr 8, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@kamalchaturvedi kamalchaturvedi kamalchaturvedi left review comments

@jasonclopper jasonclopper Awaiting requested review from jasonclopper

Assignees

@mjang mjang

Labels
product/nginx-one NGINX One Console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NGINX One Console: Add RBAC Info
5 participants
@mjang @jasonclopper @ADubhlaoich @kamalchaturvedi @JTorreG